| Violation | Line |
|---|---|
| BC: Unchecked/unconfirmed cast from org.apache.struts.action.ActionForm to class pl.agh.iosr.ballamigos.webapp.beans.MatchNameBean in pl.agh.iosr.ballamigos.webapp.actions.ChooseMatchName.execute(org.apache.struts.action.ActionMapping,org.apache.struts.action.ActionForm,javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletResponse) | 27 |
| Violation | Line |
|---|---|
| BC: Unchecked/unconfirmed cast from org.apache.struts.action.ActionForm to class pl.agh.iosr.ballamigos.webapp.beans.ChosenRoomBean in pl.agh.iosr.ballamigos.webapp.actions.ChooseRoomAction.execute(org.apache.struts.action.ActionMapping,org.apache.struts.action.ActionForm,javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletResponse) | 30 |
| Violation | Line |
|---|---|
| REC: Method pl.agh.iosr.ballamigos.webapp.actions.StatsAction.execute(org.apache.struts.action.ActionMapping,org.apache.struts.action.ActionForm,javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletResponse) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 61 |
| Violation | Line |
|---|---|
| No: Using notify rather than notifyAll in pl.agh.iosr.ballamigos.webapp.core.WebApplicationCommunicator.playerJoins(String) | 247 |
| No: Using notify rather than notifyAll in pl.agh.iosr.ballamigos.webapp.core.WebApplicationCommunicator.reciveCurrentMatch(pl.agh.iosr.ballamigos.common.Match) | 276 |
| No: Using notify rather than notifyAll in pl.agh.iosr.ballamigos.webapp.core.WebApplicationCommunicator.startMatch() | 298 |
| PS: Class pl.agh.iosr.ballamigos.webapp.core.WebApplicationCommunicator exposes synchronization and semaphores in its public interface. | 247 |
| Violation | Line |
|---|---|
| SBSC: Method pl.agh.iosr.ballamigos.webapp.jscommunication.LoadArenaServlet.doPost(javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletResponse) concatenates strings using + in a loop | 65 |
| REC: Method pl.agh.iosr.ballamigos.webapp.jscommunication.LoadArenaServlet.doPost(javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletResponse) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 70 |
| MTIA: Class pl.agh.iosr.ballamigos.webapp.jscommunication.LoadArenaServlet extends Servlet class and uses instance variables. | 27 |
| Violation | Line |
|---|---|
| SBSC: Method pl.agh.iosr.ballamigos.webapp.jscommunication.MakeDecisionServlet.receiveMove(pl.agh.iosr.ballamigos.webapp.core.WebApplicationCommunicator) concatenates strings using + in a loop | 87 |
| REC: Method pl.agh.iosr.ballamigos.webapp.jscommunication.MakeDecisionServlet.receiveMove(pl.agh.iosr.ballamigos.webapp.core.WebApplicationCommunicator) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 124 |
| MTIA: Class pl.agh.iosr.ballamigos.webapp.jscommunication.MakeDecisionServlet extends Servlet class and uses instance variables. | 29 |
| Violation | Line |
|---|---|
| REC: Method pl.agh.iosr.ballamigos.webapp.jscommunication.NewArenaServlet.doPost(javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletResponse) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 189 |
| MTIA: Class pl.agh.iosr.ballamigos.webapp.jscommunication.NewArenaServlet extends Servlet class and uses instance variables. | 29 |
| Violation | Line |
|---|---|
| Dm: pl.agh.iosr.ballamigos.webapp.tags.Restricted.<init>() invokes dubious new String(String) constructor; just use the argument | 17 |